Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exception-handling in SacessOptimizer #1512

Open
dweindl opened this issue Nov 19, 2024 · 0 comments
Open

Improve exception-handling in SacessOptimizer #1512

dweindl opened this issue Nov 19, 2024 · 0 comments
Assignees
Labels
optimization Related to optimization process

Comments

@dweindl
Copy link
Member

dweindl commented Nov 19, 2024

Currently, uncaught exceptions in SacessWorkers will result in deadlocks in SacessOptimizer.minimize. This needs to change.

@dweindl dweindl added the optimization Related to optimization process label Nov 19, 2024
@dweindl dweindl self-assigned this Nov 25, 2024
dweindl added a commit to dweindl/pyPESTO that referenced this issue Nov 25, 2024
Previously, uncaught exceptions in SacessOptimizer worker processes would have resulted in deadlocks in `SacessOptimizer.minimize`.

These changes will (in most cases) prevent deadlocks and other errors due to missing results from individual workers.
Furthermore, this will lead to termination of minimize() relatively soon after an error occurred on some worker - not only after some other exit criterion is met.

Closes ICB-DCM#1512.
dweindl added a commit to dweindl/pyPESTO that referenced this issue Nov 25, 2024
Previously, uncaught exceptions in SacessOptimizer worker processes would have resulted in deadlocks in `SacessOptimizer.minimize`.

These changes will (in most cases) prevent deadlocks and other errors due to missing results from individual workers.
Furthermore, this will lead to termination of minimize() relatively soon after an error occurred on some worker - not only after some other exit criterion is met.

Closes ICB-DCM#1512.
github-merge-queue bot pushed a commit that referenced this issue Nov 27, 2024
Previously, uncaught exceptions in SacessOptimizer worker processes would have resulted in deadlocks in `SacessOptimizer.minimize`.

These changes will (in most cases) prevent deadlocks and other errors due to missing results from individual workers.
Furthermore, this will lead to termination of minimize() relatively soon after an error occurred on some worker - not only after some other exit criterion is met.

Closes #1512.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization Related to optimization process
Projects
None yet
Development

No branches or pull requests

1 participant