Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit location for installing additional parquet index files #107

Open
fedorov opened this issue Aug 5, 2024 · 1 comment
Open

Revisit location for installing additional parquet index files #107

fedorov opened this issue Aug 5, 2024 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@fedorov
Copy link
Member

fedorov commented Aug 5, 2024

@jcfr here we are downloading additional parquet files on demand by the user, and saving them into the same location as the original files installed as part of idc-index-data installation.

@vkt1414 raised a valid concern that this is probably not the best practice. Based on your experience, can you advise where such runtime-installed files should be saved? Somewhere under user home directory?

@fedorov fedorov added the question Further information is requested label Aug 5, 2024
@fedorov
Copy link
Member Author

fedorov commented Oct 8, 2024

@jcfr from what I could find, it seems that fetching those files into user location as enabled by this package would be better: https://github.com/tox-dev/platformdirs. Do you recommend this or any other approach?

fedorov added a commit that referenced this issue Oct 9, 2024
Also address #107 by installing both indices and clinical_data into user
directory instead of the python package location.
fedorov added a commit that referenced this issue Oct 9, 2024
Also address #107 by installing both indices and clinical_data into user
directory instead of the python package location.
fedorov added a commit that referenced this issue Oct 9, 2024
Also address #107 by installing both indices and clinical_data into user
directory instead of the python package location.
fedorov added a commit that referenced this issue Oct 9, 2024
Also address #107 by installing both indices and clinical_data into user
directory instead of the python package location.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants