Missing unsubscribe

[mrpmorris]

https://github.com/JoeyMckenzie/BlazorConduit/blob/master/source/BlazorConduit.Client/Pages/Article/Article.razor#L79

This is a standard .NET event. If you don't remove your subscription then the store will keep a reference to your component instance and it will never be garbage collected, resulting in a memory leak.

Personally I wouldn't subscribe to the event. It's really only meant for people who can't descend from FluxorComponent (which you have).

I would change IsFollowing to a property:

private bool IsFollowing =>
  state.IsFollowingUser
  ?? state.CurrentArticle?.Author?.Following
  ?? false;

[shashwatsingh]

Please suggest if other places using the StateChanged event handler need an update too.

Would removing the event-handler work on unmount? Otherwise, I can look at each of the pages
individually and try to follow the suggestion above.

I could try my hand at this and other page changes -- if they need to be changed
too -- depending on what is decided.

Other changes:

$  git grep "StateChanged"
Pages/Article/Article.razor:        ArticleState.StateChanged += OnArticleLoaded;
Pages/Article/ArticleList.razor:        ArticleState.StateChanged += UpdatePagination;
Pages/Article/EditPost.razor:            State.StateChanged += UpdateEditableFields;
Pages/Profile.razor:        ProfileState.StateChanged += RefreshProfileState;
Pages/Settings.razor:        State.StateChanged += OnCurrentUserAssigned;
Shared/CustomValidationForm.razor.cs:            State!.StateChanged += DisplayValidationErrors;
Shared/NavMenu.razor:        State.StateChanged += GetUsernameOnLoginOrRegistration;