Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor textfile parsing to be unit testable #13

Open
KatieProchilo opened this issue Jun 17, 2019 · 1 comment
Open

Refactor textfile parsing to be unit testable #13

KatieProchilo opened this issue Jun 17, 2019 · 1 comment
Assignees
@Joll59 @KatieProchilo
Labels
enhancement New feature or request task Actionable work item

Comments

@KatieProchilo
Copy link
Collaborator

Separation of concerns: Logic to verify path are valid and logic for split string in .txt file should exist as stand alone not tightly coupled.

  1. parseTextFile should be split into 2 separate units, retrieveDataFromFile & splitDataIntoTestUnits, code coverage will focus on testing splitDataIntoTestUnits.
@KatieProchilo KatieProchilo added enhancement New feature or request task Actionable work item labels Jun 17, 2019
@KatieProchilo KatieProchilo self-assigned this Jun 17, 2019
@Joll59
Copy link
Owner

Joll59 commented Jun 17, 2019 •
edited
Loading

Next PR will follow advised naming convention above.
With addition of validation functions.
New method names:
validateFile
validateFolder
retrieveFileContent ===> retrieveDataFromFile
parseTextFileContent===>splitDataIntoTestUnits
createTestData ... should this be called createTestUnits ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Joll59 Joll59

@KatieProchilo KatieProchilo

Labels
enhancement New feature or request task Actionable work item
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Joll59 @KatieProchilo