build: add eslint-plugin plugin to project's lint config #708
+32
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the `eslint-plugin-eslint-plugin` recommended config to the project's lint configuration, and disables the current 25 errors, for addressing as follow-up changes.
3 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #708 +/- ##
==========================================
- Coverage 98.92% 98.85% -0.08%
==========================================
Files 17 17
Lines 1120 1135 +15
Branches 113 113
==========================================
+ Hits 1108 1122 +14
- Misses 12 13 +1 ☔ View full report in Codecov by Sentry. |
|
@all-contributors please add @michaelfaith for infra.
|
|
I've put up a pull request to add @michaelfaith! 🎉 |
JoshuaKGoldberg
pushed a commit
that referenced
this pull request
Dec 27, 2024
Adds @michaelfaith as a contributor for infra. This was requested by JoshuaKGoldberg [in this comment](#708 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
michaelfaith
added a commit
to michaelfaith/eslint-plugin-package-json
that referenced
this pull request
Dec 30, 2024
This change resolves all of the violations revealed by JoshuaKGoldberg#708, except for one. The messages used to report violations in `valid-package-def` are coming from PJV and not maintained by the plugin. So unless there's an attempt to map PJV errors to statically defined messages within the rule, that one will need to continue using `message`
3 tasks
JoshuaKGoldberg
pushed a commit
that referenced
this pull request
Dec 31, 2024
<!-- 👋 Hi, thanks for sending a PR to eslint-plugin-package-json! 💖. Please fill out all fields below and make sure each item is true and [x] checked. Otherwise we may not be able to review your PR. --> ## PR Checklist - [x] Addresses an existing open issue: fixes #81 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/blob/main/.github/CONTRIBUTING.md) were taken ## Overview This change resolves all of the violations revealed by #708, except for one. The messages used to report violations in `valid-package-def` are coming from PJV and not maintained by the plugin. So, unless there's an attempt to map PJV errors to statically defined messages within the rule, that one will need to continue using `message`. I took my best stab at defining the `type` property for the ones that were missing it. Let me know if you think any of them should be adjusted. Closes: #81
|
🎉 This is included in version v0.19.0 🎉 The release is available on: Cheers! 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
This change adds the
eslint-plugin-eslint-pluginrecommended config to the project's lint configuration, and disables the current 25 errors, for addressing as follow-up changes.Closes #82