Skip to content

Commit

Permalink
fix precompilation error printing if CI is set (#56905)
Browse files Browse the repository at this point in the history 
Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com>
  • Loading branch information
@simeonschaub @IanButterworth
simeonschaub and IanButterworth authored Dec 25, 2024
1 parent cab11bb commit e3f90c4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion base/precompilation.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1098,7 +1098,7 @@ function _precompilepkgs(pkgs::Vector{String},
direct = strict ? "" : "direct "
err_msg = "The following $n_direct_errs $(direct)dependenc$(pluralde) failed to precompile:\n$(String(take!(err_str)))"
if internal_call # aka. auto-precompilation
if isinteractive() && !get(ENV, "CI", false)
if isinteractive()
plural1 = length(failed_deps) == 1 ? "y" : "ies"
println(io, " ", color_string("$(length(failed_deps))", Base.error_color()), " dependenc$(plural1) errored.")
println(io, " For a report of the errors see `julia> err`. To retry use `pkg> precompile`")
Expand Down

6 comments on commit e3f90c4

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your job failed. Consult the server logs for more details (cc @maleadt).

@maleadt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSAIL network was rebooted. Let's try this again:

@nanosoldier runtests(isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

@vtjnash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

Please sign in to comment.