Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add categories on Plugins page #1405

Closed
Botan626 opened this issue May 23, 2021 · 4 comments
Closed

Add categories on Plugins page #1405

Botan626 opened this issue May 23, 2021 · 4 comments
Labels
👥 Duplicate Issues marked with this label are duplicate of already existing issues, they serve no purpose. ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features.

Comments

@Botan626
Copy link
Contributor

Purpose

Plugins page could give more info for the user about his setup.

Example: SteamTokenDumperPlugin is disabled in global config, but ASF-ui just showes that it's installed, not giving the user info whether it's enabled or not.

Screenshots

image

image

Solution

Add 'Installed' and 'Enabled' categories on Plugins page.
@Botan626 Botan626 added ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🧐 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels May 23, 2021
@Abrynos
Copy link
Member

Abrynos commented May 23, 2021

This would require the IPC API to provide such info, which is not possible at the moment. We COULD add a plugin interface such as IConfigurable that provides the configuration structures to ASF, which then could result in a new API endpoint, but I am not sure whether we really need/want that.

@MrBurrBurr
Copy link
Member

Pretty much what @Abrynos already said. I will close this issue for now since we already got #1012 which would make this enhancement idea possible (and would also probably include it).

@MrBurrBurr MrBurrBurr added 👥 Duplicate Issues marked with this label are duplicate of already existing issues, they serve no purpose. and removed 🧐 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels May 24, 2021
@Botan626
Copy link
Contributor Author

and would also probably include it

Add Wishlist label until it's done then? I don't see how exactly this feature request duplicates the one you mentioned above.

@MrBurrBurr
Copy link
Member

No need to. This feature request duplicates a small part of the original issue I linked.

@JustArchiNET JustArchiNET locked as resolved and limited conversation to collaborators May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
👥 Duplicate Issues marked with this label are duplicate of already existing issues, they serve no purpose. ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Abrynos @Botan626 @MrBurrBurr