Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom quick action buttons #1495

Open
wollframium opened this issue Aug 3, 2021 · 3 comments
Open

Add custom quick action buttons #1495

wollframium opened this issue Aug 3, 2021 · 3 comments
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial.

Comments

@wollframium
Copy link

in another release you said that I can safely put forward ideas, I had 2 ideas a long time ago, I saw 1 idea in the plugin https://github.com/genesix-eu/ASF_MCE, but it's complicated, I didn't understand how to set it up, but figure it out no time.
there is a very useful function:
"Button 1: will open a new window in chrome as an app with given bot's steam profile. All cached data, session, cookies and passwords will be stored in "./_data_bots/". If you press Ctrl when click, the nwjs window will be opened instead of Chrome."
as I understand it, cookies are imported into the minibrowser or something like that, and you can manage your account through the browser without entering login: pass: 2fa.
I wish I could add this to your interface) but I think it will be difficult.

An idea that I have not borrowed anywhere, these are costomized buttons. you already have a pause renewal, as I understand, when you press the pause button in the asf, the command "pause namebot" is entered.
why not add a cost-effective button. in which I would fill in my commands. in the settings of the buttons add an input field where the user will enter his command, for example loot ^ asf 570 2. the command of which the things of Dota2 are sent.
a button will be added to the bot menu, "custom commands" when you click on which a command will occur. "asf" will be replaced with the name of the bot on which the button will be.
Screenshot (1)

@wollframium wollframium added ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🧐 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels Aug 3, 2021
@Abrynos
Copy link
Member

Abrynos commented Aug 3, 2021

Hey there! 🙂

First of all thank you for your suggestions. I will just respond to things, that I know about here and leave the rest to others 😉

I saw 1 idea in the plugin https://github.com/genesix-eu/ASF_MCE

There is already a mass config editor in ASF-ui. In case you haven't noticed it yet, I recommend you update to the latest version.

Button 1: will open a new window in chrome as an app with given bot's steam profile

You can already open a given bots steam profile in a new browser tab by clicking on the profile picture of said bot on the bots page.

All cached data, session, cookies and passwords will be stored [...] and you can manage your account through the browser without entering login

Being automatically logged into that account is not possible tho and will not be possible with vanilla ASF. That would require ASF to give out session cookies and/or passwords via ASFs IPC interface. This in turn would bring way too many security concerns with it to be added to ASF core with a clear conscience. ASF already refuses to serialize sensitive fields (like passwords) and it will not render this feature void by giving out full session cookies instead.

@wollframium
Copy link
Author

so what about custom commands? Typically, you set your commands and an additional button is created next to each bot, it would be just as convenient as pause the button

Hey there! 🙂
why not add a cost-effective button. in which I would fill in my commands. in the settings of the buttons add an input field where the user will enter his command, for example loot ^ asf 570 2. the command of which the things of Dota2 are sent.
a button will be added to the bot menu, "custom commands" when you click on which a command will occur. "asf" will be replaced with the name of the bot on which the button will be.

@Abrynos
Copy link
Member

Abrynos commented Aug 4, 2021

As I said:

I will just respond to things, that I know about here and leave the rest to others

Since I am neither one of the maintainers of ASF-ui, nor do I have the willings to send a merge request for this, I cannot speak for this feature suggestion. You'll have to wait for a response from them.

@MrBurrBurr MrBurrBurr changed the title i have 2 idea Add custom quick action buttons Aug 23, 2021
@MrBurrBurr MrBurrBurr added 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial. and removed 🧐 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial.
Projects
None yet
Development

No branches or pull requests

3 participants