Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mergeInspectionData() #1

Open
hsonne opened this issue Dec 7, 2018 · 0 comments
Open

Improve mergeInspectionData() #1

hsonne opened this issue Dec 7, 2018 · 0 comments

Comments

@hsonne
Copy link
Member

hsonne commented Dec 7, 2018

  1. The function should create a column inspno in the table of inspections. I was confused that the inspno in the returned table of inspections had "gaps". However this was due to the fact that there were no observations for some inspections. We should create a column inspno also in the table of inspections in which all numbers from 1 to the number of inspections (number of rows in table inspections) occur. This reduces the risk that observations cannot be correctly assigned to their corresponding inspections.

  2. Use lapply() or purrr:map() instead of for-loop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant