Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot create a non-durable non-auto-deleted exchange #14

Open
rubenv opened this issue May 15, 2024 · 1 comment
Open

Cannot create a non-durable non-auto-deleted exchange #14

rubenv opened this issue May 15, 2024 · 1 comment

Comments

@rubenv
Copy link
Contributor

rubenv commented May 15, 2024

In manager.go there's the following:

	return manager.channel.ExchangeDeclare(
		config.Name,          // name
		config.Type.String(), // type
		config.Persisted,     // durable
		!config.Persisted,    // auto-deleted
		false,                // internal
		false,                // no-wait
		config.Args,          // arguments
	)

This does not allow creating an exchange that is not durable, yet won't be auto-deleted. Those options aren't inverse of each-other, we need to supply false, false there for our purposes.

I'm happy to supply a PR to make this possible, but don't immediately see a good path forward for doing so without a change in behavior.

@m3talux
Copy link
Collaborator

m3talux commented May 15, 2024

Yeah, I see the problem here. That would indeed be a breaking change. But at the same time, we need to expose AutoDeleted, Internal, and NoWait eventually. This breaking change is also not that critical, a simple notice in the changelog or release description for the next version should be enough to let current users know that they should set the AutoDeleted value in case the default value false is not what is intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants