From e58b48118e5605c3d77e4612c89306739ee780cf Mon Sep 17 00:00:00 2001 From: Theophile Sandoz Date: Tue, 7 Jan 2025 09:51:18 +0100 Subject: [PATCH] fix(lld): fix the default mac build by signing it (Simply by leaving `CSC_IDENTITY_AUTO_DISCOVER` to true) --- ...-builder-nosign.yml => electron-builder-nonotarize.yml} | 2 +- apps/ledger-live-desktop/package.json | 2 +- apps/ledger-live-desktop/tools/dist/index.js | 7 +++---- 3 files changed, 5 insertions(+), 6 deletions(-) rename apps/ledger-live-desktop/{electron-builder-nosign.yml => electron-builder-nonotarize.yml} (100%) diff --git a/apps/ledger-live-desktop/electron-builder-nosign.yml b/apps/ledger-live-desktop/electron-builder-nonotarize.yml similarity index 100% rename from apps/ledger-live-desktop/electron-builder-nosign.yml rename to apps/ledger-live-desktop/electron-builder-nonotarize.yml index df618e39c5b9..558798061ddf 100644 --- a/apps/ledger-live-desktop/electron-builder-nosign.yml +++ b/apps/ledger-live-desktop/electron-builder-nonotarize.yml @@ -5,8 +5,8 @@ protocols: schemes: - ledgerlive -afterPack: scripts/afterPack.js beforePack: scripts/beforePack.js +afterPack: scripts/afterPack.js mac: artifactName: ${name}-${version}-${os}.${ext} diff --git a/apps/ledger-live-desktop/package.json b/apps/ledger-live-desktop/package.json index 87a43f780db2..779c8ee17883 100644 --- a/apps/ledger-live-desktop/package.json +++ b/apps/ledger-live-desktop/package.json @@ -17,7 +17,7 @@ "scripts": { "start:prod": "electron ./.webpack/main.bundle.js", "start": "cross-env NODE_ENV=development node ./tools/main.js", - "build": "cross-env CSC_IDENTITY_AUTO_DISCOVERY=false STAGING=1 node ./tools/dist --nosign -v", + "build": "cross-env STAGING=1 node ./tools/dist --nonotarize -v", "build:js": "cross-env NODE_ENV=production node ./tools/main.js build", "build:testing": "cross-env NODE_ENV=production TESTING=1 node ./tools/main.js build", "build:staging": "cross-env NODE_ENV=production STAGING=1 node ./tools/main.js build", diff --git a/apps/ledger-live-desktop/tools/dist/index.js b/apps/ledger-live-desktop/tools/dist/index.js index 671d6b4237d1..7dc44ddc7c1c 100644 --- a/apps/ledger-live-desktop/tools/dist/index.js +++ b/apps/ledger-live-desktop/tools/dist/index.js @@ -122,9 +122,8 @@ const buildTasks = args => [ } else if (args.pre) { commands.push("--config"); commands.push("electron-builder-pre.yml"); - } else if (args.nosign) { - commands.push("--config"); - commands.push("electron-builder-nosign.yml"); + } else if (args.nonotarize) { + commands.push("--config", "electron-builder-nonotarize.yml"); commands.push("-c.afterSign='lodash/noop'"); commands.push("--publish", "never"); } @@ -242,7 +241,7 @@ yargs type: "boolean", describe: "make it a release build", }) - .option("nosign", { + .option("nonotarize", { type: "boolean", }) .option("dirty", {