Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SGA Core naming inconsistency meta2def vs build_file_meta #30

Open
ModernMAK opened this issue Nov 3, 2022 · 1 comment
Open

SGA Core naming inconsistency meta2def vs build_file_meta #30

ModernMAK opened this issue Nov 3, 2022 · 1 comment
Labels
documentation Improvements or additions to documentation SGA Relates to `Relic-Tool-SGA`

Comments

@ModernMAK
Copy link
Member

ModernMAK commented Nov 3, 2022

When writing we have meta2def but reading lacks a def2meta handler.

This currently prevents any SGA aside from V2 from creating proper EssenceFS objects.

Two separate naming conventions, one should be refactored to match the other.

Alternatively, using a class to group the strategies together, which would make it easier to create the serializers.

@ModernMAK ModernMAK added bug Something isn't working SGA Relates to `Relic-Tool-SGA` labels Nov 3, 2022
@ModernMAK ModernMAK changed the title SGA Core lacks a delegate for saving a FileDef to a file's metadata SGA Core naming inconsistency meta2def vs build_file_meta Nov 3, 2022
@ModernMAK ModernMAK added documentation Improvements or additions to documentation and removed bug Something isn't working labels Nov 3, 2022
@ModernMAK
Copy link
Member Author

ModernMAK commented May 19, 2023

Callables are nice; but having a proper protocol class would make things easier, something like InfoConverter (T <-> Dict[str,Object])? Since FS internally refers to the files' / filesystems' metadata as Info.

Also standardizing the nomenclature for these files' layout would be helpful; but that deserves its own issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation SGA Relates to `Relic-Tool-SGA`
Projects
None yet
Development

No branches or pull requests

1 participant