Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Riemann solvers, add other schemes #529

Open
sbryngelson opened this issue Jul 18, 2024 · 0 comments
Open

Refactor Riemann solvers, add other schemes #529

sbryngelson opened this issue Jul 18, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@sbryngelson
Copy link
Member

  1. The Riemann solvers module currently doesn't separate between the physical fluxes (\rho u^2 + p, for example) and the numerical fluxes (e.g., what comes out of HLL/HLLC/Lax-Friedrichs). This is an easy win and an improvement to the code.

  2. We can easily add more rudimentary Riemann solvers like Lax-Friedrichs and its sisters (global LF, local LF, Rusanov) and maybe others, like Roe. Some of these were in older archived versions of MFC available in the GH org., though became unwieldy as we added physics. These are useful for some numerics testing, and they become easy to add once 1. is accomplished.

@sbryngelson sbryngelson added the enhancement New feature or request label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant