Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI duplicates code to build MFC #660

Open
sbryngelson opened this issue Oct 22, 2024 · 1 comment
Open

CI duplicates code to build MFC #660

sbryngelson opened this issue Oct 22, 2024 · 1 comment
Labels
continuous-integration Continuous integration (CI) enhancement New feature or request good first issue Good for newcomers

Comments

@sbryngelson
Copy link
Member

sbryngelson commented Oct 22, 2024

Different CI files all do the same thing, something like calling this:

sudo apt install -y tar wget make cmake gcc g++ python3 python3-dev "openmpi-*" libopenmpi-dev

Which isn't really a big deal, until we change dependencies or something.

It would be useful if maybe we had a way of consolidating this? Or even exposing it to the user for different OSs.

For example, right now I think the linked line needs to apt install fftw.

@sbryngelson sbryngelson added enhancement New feature or request continuous-integration Continuous integration (CI) labels Oct 22, 2024
@sbryngelson
Copy link
Member Author

The solution is probably to create a script that runs the appropriate build commands for different OSs and keep it in version control somewhere. The script can even be one or two lines long, but then it's DRY and we can change build commands once.

Would recommend cating this script before running it in CI so the user knows what was run.

@henryleberre henryleberre added the good first issue Good for newcomers label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous-integration Continuous integration (CI) enhancement New feature or request good first issue Good for newcomers
Development

No branches or pull requests

2 participants