Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove chemistry as a fypp macro #678

Closed
sbryngelson opened this issue Nov 4, 2024 · 1 comment
Closed

Remove chemistry as a fypp macro #678

sbryngelson opened this issue Nov 4, 2024 · 1 comment
Assignees
@henryleberre
Labels
enhancement New feature or request

Comments

@sbryngelson
Copy link
Member

Try removing chemistry's fypp macro and into a usual if statement for more 'normal' code that is all compiled regardless of chemistry being T or F (a coherent source code regardless of features used).

Will involve using a 'dummy' reaction mechanism.

May need performance testing.

Discussed here

Originally posted by @sbryngelson in #653 (comment)
@sbryngelson sbryngelson added the enhancement New feature or request label Nov 4, 2024
@sbryngelson sbryngelson mentioned this issue Nov 4, 2024
Merged
2 tasks
@sbryngelson
Copy link
Member Author

This was closed by PR #653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henryleberre henryleberre

Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
2 participants
@henryleberre @sbryngelson