Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing broken example CI cases #751

Open
sbryngelson opened this issue Dec 3, 2024 · 0 comments
Open

Fixing broken example CI cases #751

sbryngelson opened this issue Dec 3, 2024 · 0 comments
Assignees
@okBrian
Labels
bug Something isn't working or doesn't seem right continuous-integration Continuous integration (CI) enhancement New feature or request

Comments

@sbryngelson
Copy link
Member

sbryngelson commented Dec 3, 2024 •
edited
Loading

The current example cases do not pass the CI setup by @okBrian under this PR: #664

The failing cases were:

["2D_ibm_cfl_dt", "1D_sodHypo", "2D_viscous", 
"2D_laplace_pressure_jump", "2D_bubbly_steady_shock", 
"2D_advection", "2D_hardcodied_ic", "2D_ibm_multiphase"]

These mostly fail due to tolerance issues. They can likely be resolved by looking at the examples and adjusting them. This is a to-do for @okBrian but will require input from others about what might not be quite right with these cases.
@sbryngelson sbryngelson added bug Something isn't working or doesn't seem right enhancement New feature or request continuous-integration Continuous integration (CI) labels Dec 3, 2024
@sbryngelson sbryngelson mentioned this issue Dec 3, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@okBrian okBrian

Labels
bug Something isn't working or doesn't seem right continuous-integration Continuous integration (CI) enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sbryngelson @okBrian