New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single/modular precision fix ups #759

Open

sbryngelson opened this issue Dec 16, 2024 · 0 comments

Assignees

Labels

Member

sbryngelson commented Dec 16, 2024 •

edited

Loading

Some fix-ups relevant to PR #632 by @arciyer123

These cases are skipped in testing. I'm not sure why.
- 1D -> 2 MPI Ranks, 2D -> 2 MPI Ranks, 3D -> 2 MPI Ranks
Add benchmark check that ensures we see the expected speedup of single over double precision (and throw a non-zero stop code if we don't)

These are the two most pressing, I think. Everything else I can think of is more of a feature than something that needs to be fixed.

Update:

I also see that the single precision tests don't test the examples. Not sure how that happened. It might have happened via a merged PR or perhaps always like that. Either way, we should look into fixing it.

sbryngelson added the enhancement label

sbryngelson assigned aricer123

sbryngelson mentioned this issue

Add modular precision update #632

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment