Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable data on items of an order #17

Open
Folas1337 opened this issue Oct 3, 2024 · 1 comment
Open

Option to disable data on items of an order #17

Folas1337 opened this issue Oct 3, 2024 · 1 comment
Assignees

Comments

@Folas1337
Copy link

Describe the solution you'd like
I never specified this but #2 made me realize I didn't really want people to be able to ask for super specific items in their order, I just want them to ask for the base item(s).

So a config option to turn off that ability somehow would be neat. Either that disables /order create hand and similar commands OR it converts the item with data you are holding into a regular item with no data attached (not even vanilla one). Personally I would prefer the latter as it's more future proof (if you add other ways to create an order in the future, that won't be a problem and something that could turn into a bug).

Cause right now I could probably ask for the most specific banner or book you've ever seen and nobody would really be able to fulfill that order which is why, from the start, I was expecting this plugin to only demand for the "base item" and not one with data attached. Sorry if that wasn't so clear 😅

...
Although after more testing I realized that at least the book doesn't work but still I want to make sure it's always just base items and if that's already the case, make it toggleable if you implement #2 :)

@MRollin03
Copy link
Owner

Hi Quick question. When you say it does not work for books. Does it transfer the (custom) items metadata with other items? Haven't tested it myself but wouldn't think it would work. 🧐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants