Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline Chart Data Parsing + Video Sync #129

Open
gr812b opened this issue Oct 14, 2024 · 0 comments
Open

Streamline Chart Data Parsing + Video Sync #129

gr812b opened this issue Oct 14, 2024 · 0 comments
Labels
code quality Improve the current code frontend Involves the React Typescript frontend.

Comments

@gr812b
Copy link
Collaborator

gr812b commented Oct 14, 2024 •
edited
Loading

There's a lot of pretty repetitive code inside the chart data and video sync lines that could be cleaned up a lot.

  • Combining the handling of colour charts and all others requires a lot of duplicated cases, and if we come along with a separate data type for it, it will only multiply. Would be great if this could be separated / abstracted out.
  • Similar to chart video sync lines. Currently only have vertical or vert + hori bars, handled with an if. Preferably we have separate flows for them

Other than that, code is just messy.
@gr812b gr812b added the code quality Improve the current code label Oct 14, 2024
@gr812b gr812b mentioned this issue Oct 14, 2024
Merged
2 tasks
@gr812b gr812b added the frontend Involves the React Typescript frontend. label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Improve the current code frontend Involves the React Typescript frontend.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gr812b