Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Try with Resources #151

Open
gr812b opened this issue Nov 29, 2024 · 0 comments
Open

Refactor: Try with Resources #151

gr812b opened this issue Nov 29, 2024 · 0 comments
Labels
backend Involves the Java Quarkus backend. bug Something isn't working

Comments

@gr812b
Copy link
Collaborator

gr812b commented Nov 29, 2024

Current implementation of the analyzers is to open the required readers and writers, perform the operation, then close them. This means that on a crash, the file gets stuck in an inaccessible mode due to the lock. This should be done instead using a try with resources block. Ideally, this does not impact the current error handling method, and simply ensures the writers and readers are closed, while still throwing previous errors. Further, look into patterns that won't be super ugly.

@gr812b gr812b added bug Something isn't working backend Involves the Java Quarkus backend. labels Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Involves the Java Quarkus backend. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant