Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly urlencode pic cached documents #184

Closed
fgregg opened this issue Jul 19, 2017 · 5 comments
Closed

properly urlencode pic cached documents #184

fgregg opened this issue Jul 19, 2017 · 5 comments
Milestone

Comments

@fgregg
Copy link
Collaborator

fgregg commented Jul 19, 2017

I made a number of changes to make our document cache much more robust. Before deploying we need to make sure that we are properly urlencoding the urls. As we do this in a few places, I'm going to wait till @reginafcompton comes back to deploy the changes to the document cache to production.

@reginafcompton
Copy link
Contributor

reginafcompton commented Jul 24, 2017

Use the pic-staging.datamade for the new url.

@reginafcompton reginafcompton added this to the July Issues milestone Jul 25, 2017
@reginafcompton
Copy link
Contributor

I have an initial solution for this on the pic branch. It works with pic-staging.datamade.us.

However, it seems that we actually want to create a standardized version of full_text_doc_url in django-councilmatic core. We can use the work on the pic branch as a good starting point.

datamade/django-councilmatic#136

@shrayshray shrayshray modified the milestones: July Issues, August issues Aug 3, 2017
@reginafcompton
Copy link
Contributor

reginafcompton commented Aug 14, 2017

This PR closes this issue.

Related: The PIC changes are working well. Currently, we have LA Metro pointing to pic-staging.datamade.us. @fgregg let me know if you'd like to deploy PIC to production, and we can point LA Metro accordingly.

@fgregg
Copy link
Collaborator Author

fgregg commented Aug 14, 2017 via email

@reginafcompton
Copy link
Contributor

PIC is deployed to production, and LA Metro points to pic.datamade.us.

Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants