-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is ARA robokop still running? #524
Comments
ah, found this: NCATSTranslator/Relay#473 |
Should we close this issue? |
Does not seem fixed to me |
I don't think it's fixed yet, no. I believe the ARS is still contacting Robokop. However, Robokop has been delisted from smartapi. |
okay, thanks. There seems to be a pretty substantial disconnect between ARS and SmartAPI. What do we want ARS to be doing? I think this may be a topic for the Architecture Cttee? @cbizon ? |
I suspect this is an issue for the ARS team @MarkDWilliams @ShervinAbd92 . Or perhaps better a topic for Architecture call on how we all agree that the ARS should be operating. Based on observing what happens, I suspect that ARS has a hard-coded set of endpoints that it hits, and it is not based on SmartAPI. and that hard-coded list hasn't been updated in a long time. But I am uncertain. ah, looking again this morning, it seems that Robokop has now been removed: The issue that ARS still hits a subset of KPs remains:
This seems like a policy issue that should be discussed at Architecture. |
@MarkDWilliams can you comment here please on these issues? |
Happy to reassess what the ARS hits. As to the URLs, there shouldn't be any hardcoded URLs that we hit that aren't based on SmartAPI. However, there is a hard coded fallback that can come into play if for some reason, there was a failure to pull the current information from SmartAPI for some reason, but barring that, all the URLs should be pulled from SmartAPI at boot time. |
So the lag between ROBOKOP being de-listed on SmartAPI and ARS is just because ARS didn't refresh? |
Ah no, that would be a case where likely the ARS wasn't able to find the registration and falling back to the URL we have in the backup config file. This behavior could be changed to have the ARS just skip anything it can't get a SmartAPI pull for if folks think that would be preferable. |
fixable this month on the ARS side. |
robokop agent has been removed from ARS side. |
It seems like whenever I look at recent ARS results, robokop always returns a 404 error. Why is that? Is that okay?
https://arax.ci.transltr.io/?latest=10&from=ars.test.transltr.io
https://arax.ci.transltr.io/?latest=10&from=ars.ci.transltr.io
The text was updated successfully, but these errors were encountered: