Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is ARA robokop still running? #524

Closed
edeutsch opened this issue Sep 8, 2023 · 13 comments
Closed

Is ARA robokop still running? #524

edeutsch opened this issue Sep 8, 2023 · 13 comments
Assignees

Comments

@edeutsch
Copy link

edeutsch commented Sep 8, 2023

It seems like whenever I look at recent ARS results, robokop always returns a 404 error. Why is that? Is that okay?

https://arax.ci.transltr.io/?latest=10&from=ars.test.transltr.io
image

https://arax.ci.transltr.io/?latest=10&from=ars.ci.transltr.io
image

@edeutsch
Copy link
Author

edeutsch commented Sep 8, 2023

ah, found this: NCATSTranslator/Relay#473

@sandrine-m
Copy link

Should we close this issue?

@edeutsch
Copy link
Author

Does not seem fixed to me

@uhbrar
Copy link

uhbrar commented Sep 11, 2023

I don't think it's fixed yet, no. I believe the ARS is still contacting Robokop. However, Robokop has been delisted from smartapi.

@edeutsch
Copy link
Author

okay, thanks. There seems to be a pretty substantial disconnect between ARS and SmartAPI. What do we want ARS to be doing? I think this may be a topic for the Architecture Cttee? @cbizon ?
See also NCATSTranslator/Relay#501 (comment)

@sierra-moxon
Copy link
Member

@newgene - just wanted to get your feedback on the next steps here to hopefully resolve the disconnect between ARS and SmartAPI that @edeutsch notes? Do we need this to go to a particular team or is it a discussion-level ticket?

@edeutsch
Copy link
Author

edeutsch commented Nov 3, 2023

I suspect this is an issue for the ARS team @MarkDWilliams @ShervinAbd92 . Or perhaps better a topic for Architecture call on how we all agree that the ARS should be operating. Based on observing what happens, I suspect that ARS has a hard-coded set of endpoints that it hits, and it is not based on SmartAPI. and that hard-coded list hasn't been updated in a long time. But I am uncertain.

ah, looking again this morning, it seems that Robokop has now been removed:
https://arax.ci.transltr.io/?latest=10&from=ars.ci.transltr.io

The issue that ARS still hits a subset of KPs remains:
https://arax.ci.transltr.io/?r=46c9678f-52fe-4c72-ad97-265852ed262e
Do we want ARS to be doing that? Should ARS:

  • Continue to hit a subset of KPs
  • Hit only ARAs and not KPs
  • Hit all KPs based on SmartAPI instead of a hard-coded subset?

This seems like a policy issue that should be discussed at Architecture.

@cbizon
Copy link
Collaborator

cbizon commented Nov 6, 2023

@MarkDWilliams can you comment here please on these issues?

@MarkDWilliams
Copy link
Contributor

Happy to reassess what the ARS hits. As to the URLs, there shouldn't be any hardcoded URLs that we hit that aren't based on SmartAPI. However, there is a hard coded fallback that can come into play if for some reason, there was a failure to pull the current information from SmartAPI for some reason, but barring that, all the URLs should be pulled from SmartAPI at boot time.

@cbizon
Copy link
Collaborator

cbizon commented Nov 7, 2023

So the lag between ROBOKOP being de-listed on SmartAPI and ARS is just because ARS didn't refresh?

@MarkDWilliams
Copy link
Contributor

Ah no, that would be a case where likely the ARS wasn't able to find the registration and falling back to the URL we have in the backup config file. This behavior could be changed to have the ARS just skip anything it can't get a SmartAPI pull for if folks think that would be preferable.

@sierra-moxon
Copy link
Member

fixable this month on the ARS side.
from tAQA: just kill it.

@ShervinAbd92
Copy link

robokop agent has been removed from ARS side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants