From 82f99c3466cbeb283d47803bd6ba64b1596d5717 Mon Sep 17 00:00:00 2001 From: Jake Hemstad Date: Tue, 24 Oct 2023 14:58:27 -0500 Subject: [PATCH] Use always() instead of !cancelled() Normally you want to avoid `always()` in favor of `!cancelled()`, but in this case we want to use `always()` because using `!cancelled()` would lead to the `ci` job being skipped, which would report as a success for the status check. --- .github/workflows/pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index ae2af792e6c..9def8800cba 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -154,7 +154,7 @@ jobs: ci: runs-on: ubuntu-latest name: CI - if: ${{ !cancelled() }} + if: ${{ always() }} # need to use always() instead of !cancelled() because skipped jobs count as success needs: - clang-cuda - cub