Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Support FP8 in Block Radix Sort #590

Closed
1 task done
gevtushenko opened this issue Oct 20, 2023 · 0 comments · Fixed by #623
Closed
1 task done

[FEA]: Support FP8 in Block Radix Sort #590

gevtushenko opened this issue Oct 20, 2023 · 0 comments · Fixed by #623
Assignees
Labels
feature request New feature or request.

Comments

@gevtushenko
Copy link
Collaborator

gevtushenko commented Oct 20, 2023

Is this a duplicate?

Area

CUB

Is your feature request related to a problem? Please describe.

CUB radix sort doesn't support FP8. The code below doesn't compile:

__global__ void kernel() {
  using block_radix_sort_t = cub::BlockRadixSort<__nv_fp8_e4m3, 32, 1>;
  using temp_storage_t = block_radix_sort_t::TempStorage;

  __shared__ temp_storage_t temp_storage;

  __nv_fp8_e4m3 fp8[1]{__nv_fp8_e4m3(static_cast<float>(threadIdx.x))};

  block_radix_sort_t(temp_storage).SortDescending(fp8);
}

Describe the solution you'd like

FP8 support is documented and tested.

Describe alternatives you've considered

No response

Additional context

No response

@gevtushenko gevtushenko added the feature request New feature or request. label Oct 20, 2023
@github-project-automation github-project-automation bot moved this to Todo in CCCL Oct 20, 2023
@gevtushenko gevtushenko self-assigned this Oct 20, 2023
@gevtushenko gevtushenko moved this from Todo to In Progress in CCCL Oct 20, 2023
@cccl-authenticator-app cccl-authenticator-app bot moved this from In Progress to In Review in CCCL Oct 26, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant