Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Cleanup unneeded user defined destructors on thrust #595

Open
1 task done
miscco opened this issue Oct 22, 2023 · 0 comments
Open
1 task done

[FEA]: Cleanup unneeded user defined destructors on thrust #595

miscco opened this issue Oct 22, 2023 · 0 comments
Labels
feature request New feature or request.

Comments

@miscco
Copy link
Collaborator

miscco commented Oct 22, 2023

Is this a duplicate?

Area

Thrust

Is your feature request related to a problem? Please describe.

Thrust is often defining empty destructors ~meow(){}

This is actually a potential pessimization so we should remove those occurences

Describe the solution you'd like

Remove all empty destructors as they can be compiler provided.

We need to make sure that they are not intentionally dropping destructors of inherited classes, but that would be a whole other set of problems

Describe alternatives you've considered

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request.
Projects
Status: Todo
Development

No branches or pull requests

1 participant