Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[do not merge]
std::linalg
accessors andtransposed_layout
#2962base: main
Are you sure you want to change the base?
[do not merge]
std::linalg
accessors andtransposed_layout
#2962Changes from 46 commits
dee9385
0a33496
fb03ff2
c5c6fa4
ce2cc84
1bf05d0
1a261ff
8db4036
f48792a
67c59f9
9d913be
77c2d66
3d06282
c3d1464
5390bd1
626f63a
baa26f6
4cce6e6
5031fb6
8d20f84
bdee5a3
10c0f0a
feed72e
30cf216
a39d27a
9699ce5
2da684d
8746de6
6445b49
cf34003
ad47459
9c621a5
6d521d8
ea0038f
6f18bee
4411e5d
22c37f6
fe7d176
48483f4
7fb5d60
627d354
b565ad6
5af13ad
103f1b6
377bf53
eef1e17
de30054
8093083
140c843
ec199d0
71c7211
7b529bd
03e7387
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: I assume we have this license header because the implementation was taken over from Kokkos. But should we remove Christian Trott as contact for question nevertheless? I don't know whether he wants to answer to bugs in libcu++ :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mdspan implementation for llvm is licensed differently: https://github.com/llvm/llvm-project/blob/main/libcxx/include/__mdspan/mdspan.h
We should reach out to the kokkos project to see if they would agree to a similar license
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, Christian is fine with it