Make get_global_resource host/device #3040
Conversation
|
@miscco FYI |
|
Thanks @Artem-B I was stretched a bit thin the last weeks. |
|
/ok to test |
Head branch was pushed to by a user without write access
The function is called from a host/device constructors and may be invoked from the device code. As it happens neither NVCC nor clang diagnose such an invalid call. llvm/llvm-project#118415 As the result, in unoptimized builds we end up with ptxas failing with an unresolved reference to this function because it is never generated during GPU-side compilation. NVIDIA#2813 (comment)
|
@miscco looks like my rebase to update the branch has disabled auto-merge. Can you get it going again, please? |
|
/ok to test |
|
Oh its broken because NVCC cannot handle dynamic initialization in a function local So I am wondering whether we need to restrict this to only clang-cuda for now |
| @@ -204,7 +204,7 @@ _CCCL_HOST_DEVICE bool operator!=(const memory_resource<Pointer>& lhs, const mem | |||
| * \return a pointer to a global instance of \p MR. | |||
| */ | |||
| template <typename MR> | |||
| _CCCL_HOST MR* get_global_resource() | |||
There was a problem hiding this comment.
Where is this getting used in a host/device function?
There was a problem hiding this comment.
cccl/thrust/thrust/mr/allocator.h
Lines 204 to 206 in f4d358a
Interesting. It looks like the issue I've ran into before #2813 (comment) The error went away with clang after disabling initializer guards, which suggests that the initializer is indeed empty, as far as clang was concerned, but it's possible that there are some differences about what exactly is considered to be empty. |
Description
The function is called from a host/device constructors and may be invoked from the device code.
As it happens neither NVCC nor clang diagnose such an invalid call. llvm/llvm-project#118415
As the result, in unoptimized builds we end up with ptxas failing with an unresolved reference to this function because it is never generated during GPU-side compilation.
#2813 (comment)
closes #3023
Checklist