Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to add private ratings to movies #18

Open
veyndan opened this issue Feb 15, 2022 · 1 comment
Open

Add ability to add private ratings to movies #18

veyndan opened this issue Feb 15, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@veyndan
Copy link
Contributor

veyndan commented Feb 15, 2022

I currently use iMDB to store movies that I've watched by adding a rating to the movie. I rate them to remind myself what I thought of the movie, as sometimes it's been several years since I last watched it. I'd love to be able to add ratings to movies that I've watched (i.e., an integer from 1-10), as I want to move away from iMDB without losing this ability. These ratings would be completely private to me (i.e., I don't care about having the aggregate user rating of a film that iMDB offers).

I'm not sure whether this is in the scope of the project or not, but if it is, I'd be happy to have a go at implementing it!

@NoelDeMartin
Copy link
Owner

Hey, thanks for opening an issue!

Yes, this is one of the 100s of things I would like to do eventually, so it is in the scope. But I don't plan to do it anytime soon, as I have other things I wanted to do before (like tracking TV Shows).

However, if you want to try doing it, I'm willing to help you :D. I think it should be fairly easy to implement, but it may take you some time to understand the codebase (I'm not sure because so far I'm the only one who's been working on it).

My initial ideal is that it can be done using the schema:review property for a schema:Movie. And the modeling would be very similar to how watched movies are tracked using a WatchAction, but using a belongsTo relationship instead of hasMany. As for the UI, I think it should be easy to add the rating in the movie page. Given that you're only interested in storing the information, I wouldn't bother adding it to the grid view or elsewhere, because I'm planning on refactoring it eventually to show more information and improve filters/sorting. Although if you come up with a simple addition that is not too intrusive I'd be ok with that. But keep in mind that I'll probably remove it later.

If you haven't, I suggest that you read the documentation and feel free to ask me any questions.

@NoelDeMartin NoelDeMartin added the enhancement New feature or request label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants