Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Loading text doesn't go away when searching for mods by peerId #1862

Open
rmisio opened this issue Jan 15, 2020 · 2 comments
Open

Loading text doesn't go away when searching for mods by peerId #1862

rmisio opened this issue Jan 15, 2020 · 2 comments
Assignees

Comments

@rmisio
Copy link
Contributor

rmisio commented Jan 15, 2020

This was tested against the refactorModLoading branch.

Steps to reproduce:

  • In Settings > Store, search for a mod by peerId
  • When the mod loads, click Find to search for the same mod.

Observed:
Loading moderator 1 of 1 is shown and never goes away.

image

Expectations:

  • Perhaps Loading moderator 1 of 1 shows briefly or not at all, but it doesn't stay perpetually.

Similar issue:

Steps to reproduce:

  • In Settings > Store, search for a valid Mod by peerId and wait until the mod loads.
  • Search for a non-existent peer by peerId (the peerId should be a valid multihash, just not map to a reachable OB node)

Observed:
An error message is shown indicating the node was not reached and Loading moderator 1 of 1 is shown and never goes away.

image

Expectations:

  • Loading moderator 1 of 1 disappears after it's determined the peerId was not found and the error message is shown.
@rmisio
Copy link
Contributor Author

rmisio commented Feb 3, 2020

@jjeffryes The second part of this issue (under the Similar issue: text) is still an issue. Should I break that out into a seperate issue that you could circle back to at some later time?

@jjeffryes
Copy link
Contributor

@jjeffryes The second part of this issue (under the Similar issue: text) is still an issue. Should I break that out into a seperate issue that you could circle back to at some later time?

I'll tackle that as part of this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants