From e326d65c9ecf51652c3bc6d3fad8eb893c6dba25 Mon Sep 17 00:00:00 2001
From: "Xie, Lin" <lin.xie@intel.com>
Date: Tue, 17 Dec 2024 11:11:43 +0800
Subject: [PATCH] Append changes to address comment

---
 README.md                  |  2 +-
 build.sh                   |  1 -
 docs/docker_image_build.md |  1 +
 ivsr_setupvar.sh           | 31 -------------------------------
 4 files changed, 2 insertions(+), 33 deletions(-)
 delete mode 100755 ivsr_setupvar.sh

diff --git a/README.md b/README.md
index 7ee423c..448c3c5 100644
--- a/README.md
+++ b/README.md
@@ -187,7 +187,7 @@ The `vsr_sample` is developed using the iVSR SDK and OpenCV. For detailed instru
 After applying the FFmpeg plugin patches and building FFmpeg, refer to [the FFmpeg command line samples](ivsr_ffmpeg_plugin/README.md#how-to-run-inference-with-ffmpeg-plugin) for instructions on running inference with FFmpeg.
 
 # 4. Model files
-iVSR supports only models in OpenVINO IR format. Contact your Intel representative to obtain the model files, as they are not included in the package.
+iVSR supports only models in OpenVINO IR format. Contact your Intel representative to obtain the model files, as they are not included in the repo.
 
 # 5. License
 iVSR is licensed under the BSD 3-clause license. See [LICENSE](LICENSE.md) for details.
diff --git a/build.sh b/build.sh
index ea4fa39..f783c99 100755
--- a/build.sh
+++ b/build.sh
@@ -46,7 +46,6 @@ install_openvino_from_source() {
     git config --global --add safe.directory ${ivsr_ov_dir}
   fi
   cd ${ivsr_ov_dir}
-  #git checkout ${OV_BRANCH}
   git submodule update --init --recursive
 
   ## applying ov22.3 patches to enable Enhanced BasicVSR model
diff --git a/docs/docker_image_build.md b/docs/docker_image_build.md
index 64ef5e0..9d17cef 100644
--- a/docs/docker_image_build.md
+++ b/docs/docker_image_build.md
@@ -38,6 +38,7 @@ sudo docker run -itd --name ffmpeg_ivsr_sdk_container --privileged \
   -e https_proxy=$https_proxy \
   -e no_proxy=$no_proxy \
   --shm-size=128g \
+  --device=/dev/dri:/dev/dri \
   ffmpeg_ivsr_sdk_<os_version>_<ov_version>:latest bash
 
 # Open another shell terminal to interact with the running container
diff --git a/ivsr_setupvar.sh b/ivsr_setupvar.sh
deleted file mode 100755
index 92a89cc..0000000
--- a/ivsr_setupvar.sh
+++ /dev/null
@@ -1,31 +0,0 @@
-#!/bin/bash
-OV_VERSION="2022.3"
-# Parse the --ov_version
-while [ $# -gt 0 ]; do
-    case "$1" in
-        --ov_version)
-            shift
-            if [ "$1" = "2022.3" ] || [ "$1" = "2023.2" ] || [ "$1" = "2024.5" ]; then
-                OV_VERSION=$1
-            else
-                echo "Usage: $0  --ov_version [2022.3|2023.2|2024.5]"
-                exit 1
-            fi
-            shift
-            ;;
-        *)
-            echo "Usage: $0  --ov_version [2022.3|2023.2|2024.5]"
-            exit 1
-            ;;
-    esac
-done
-PROJECTDIR=${PWD}
-IVSR_OV_DIR=${PROJECTDIR}/ivsr_ov/based_on_openvino_${OV_VERSION}/openvino
-CUSTOM_OV_INSTALL_DIR=${IVSR_OV_DIR}/install
-IVSR_SDK_DIR=${PROJECTDIR}/ivsr_sdk/
-CUSTOM_IE_DIR=${CUSTOM_OV_INSTALL_DIR}/runtime
-CUSTOM_IE_LIBDIR=${CUSTOM_IE_DIR}/lib/intel64
-export OpenCV_DIR=${PROJECTDIR}/../opencv-4.5.3-openvino-2021.4.2/install/lib/cmake/opencv4
-export LD_LIBRARY_PATH=${PROJECTDIR}/../opencv-4.5.3-openvino-2021.4.2/install/lib:${IVSR_SDK_DIR}/lib:${CUSTOM_IE_DIR}/3rdparty/tbb/lib:/usr/local/lib:${CUSTOM_IE_LIBDIR}:$LD_LIBRARY_PATH
-bash ${CUSTOM_OV_INSTALL_DIR}/setupvars.sh
-sudo ldconfig