Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of ModMenu #1

Open
kmorales13 opened this issue Apr 8, 2021 · 10 comments
Open

Implementation of ModMenu #1

kmorales13 opened this issue Apr 8, 2021 · 10 comments

Comments

@kmorales13
Copy link

Hello. I've implemented your library into my mod, and so far it works great.
I just have one small issue, and that is that the modMenu integration doesn't seem to work for me.

This is the error I get in the console:
Mod provides a broken implementation of ModMenuApi

My config class https://pastebin.com/2hd5gr1d

@OroArmor
Copy link
Collaborator

OroArmor commented Apr 9, 2021

Could i see your modmenu entry point?

@kmorales13
Copy link
Author

kmorales13 commented Apr 9, 2021

"entrypoints": {
    "main": ["net.sleeppunisher.SleepPunisher"],
    "modmenu": ["net.sleeppunisher.ModMenuIntegration"]
  },
package net.sleeppunisher;

import com.oroarmor.config.screen.ModMenuConfigScreen;

public class ModMenuIntegration extends ModMenuConfigScreen {
    public ModMenuIntegration() {
		super(SleepPunisher.CONFIG);
	}
}

@OroArmor
Copy link
Collaborator

and what version of modmenu are you using?

@kmorales13
Copy link
Author

2.1.0

@OroArmor
Copy link
Collaborator

Modmenu, not oro config, sorry. Also apologies for the late response, I turned some of my github notifications down and it made things worse

@kmorales13
Copy link
Author

ah my bad, its 1.16.8. no worries

@OroArmor
Copy link
Collaborator

Huh yeah everything should be fine. Do you have a repository I could look at/tinker with?

@kmorales13
Copy link
Author

yup here's my mod, it's missing the entrypoint btw

@ChocolateLoverRaj
Copy link

My mod also has a broken implementation.

@ChocolateLoverRaj
Copy link

ChocolateLoverRaj commented Jul 9, 2021

it's missing the entrypoint btw

@kmorales13 can you commit your latest changes and then tell us the branch (if it's on another branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants