Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUGGESTION: revert static calcgrapplereach to non-static. #53

Open
ghost opened this issue Aug 10, 2021 · 1 comment
Open

SUGGESTION: revert static calcgrapplereach to non-static. #53

ghost opened this issue Aug 10, 2021 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ghost
Copy link

ghost commented Aug 10, 2021

In code\botlib\be_aas_reach.c(80): calcgrapplereach was declared as static (by this commit: 399776a#diff-0c98e2ac55938febc3ba71de80dbd443baa0f24a32e870ac327541ef5a5d959a).
This isn't a problem as long as you won't compile any BSPC tool which relies on your actual WoP botlib code.
Ofc. it's up to you to keep it static or not, I just recommend to either revert calcgrapplereach to non-static or make a statement to the code that the BSPC code relies on this piece of code, hence it shouldn't be static.
Anyways, this isn't a major issue, what I'm talking about is more like a hint than a bug report.
I don't remember if all or just a few BSPC code bases really need the dependency of be_aas_reach.c (2.1h, RtCW, OA, Warsow, Spearmint BSPC etc.)

@mgerhardy
Copy link
Member

Right now we maintain a different version of the botlib at https://github.com/PadWorld-Entertainment/bspc/commits/master - my initial goal was to include it into the main repository and share the code. But right now the bspc code just segfaults when compiling a map. On the long run we should still integrate it into the main repo - and then this "issue" must get fixed.

@kai-li-wop kai-li-wop transferred this issue from PadWorld-Entertainment/worldofpadman-fork Dec 6, 2021
@kai-li-wop kai-li-wop added the bug Something isn't working label Dec 6, 2021
@kai-li-wop kai-li-wop added this to the v1.7.0 milestone Dec 6, 2021
@kai-li-wop kai-li-wop moved this to Backlog in WoP 1.7.x Mar 14, 2022
@kai-li-wop kai-li-wop modified the milestones: v1.7.0, backlog Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

2 participants