Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update font to public sans #368

Open
1 of 3 tasks
josh-chamberlain opened this issue Jul 23, 2024 · 7 comments
Open
1 of 3 tasks

update font to public sans #368

josh-chamberlain opened this issue Jul 23, 2024 · 7 comments
Labels
front end good first issue Good for newcomers

Comments

@josh-chamberlain
Copy link
Contributor

josh-chamberlain commented Jul 23, 2024 •
edited
Loading

Context

We switched to Public Sans: Police-Data-Accessibility-Project/design-system#95
Related to Police-Data-Accessibility-Project/pdap.io#178

Requirements

  <link rel="preconnect" href="https://fonts.googleapis.com">
  <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
  <link href="https://fonts.googleapis.com/css2?family=Public+Sans:wght@100..900&display=swap" rel="stylesheet">
@josh-chamberlain josh-chamberlain mentioned this issue Jul 23, 2024
Closed
4 tasks
@josh-chamberlain josh-chamberlain added the good first issue Good for newcomers label Jul 23, 2024
@phillitrOSU
Copy link

Hi, I'd like to tackle this.

@josh-chamberlain
Copy link
Contributor Author

@phillitrOSU thanks, feel free to take a crack at it!

You shouldn't need many of the environment variables since this is just a visual change. If you wouldn't mind taking care of the related issue (same thing in another repo) it'll help keep things looking similar.

the design-system version needs to be this one for this to work. I think we might want to wait until we merge beta into main, though, which we can do imminently. I'll reach out to @joshuagraber

@joshuagraber
Copy link
Contributor

Hey @phillitrOSU I've released v3.0.0 of pdap-design-system, so you should be good to bump to that version and tackle this.

@josh-chamberlain We'll need to merge this basic PR before @phillitrOSU begins work here, as we still had one stray instance of one of the deprecated components that are now removed in the design system. Glad I thought to check that 😅 .

@josh-chamberlain
Copy link
Contributor Author

nice catch @joshuagraber, for the main site we'll want to close this one too Police-Data-Accessibility-Project/pdap.io#164

@joshuagraber
Copy link
Contributor

For sure @josh-chamberlain I'll tackle this next week.

@phillitrOSU
Copy link

Thanks guys : ). Really interested in this project in general. I'll take a look tomorrow and see if I can get it and related issue taken care of.

@phillitrOSU
Copy link

#373

@josh-chamberlain josh-chamberlain mentioned this issue Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
front end good first issue Good for newcomers
Projects
Good First Issues
Status: To do
Open issues & Roadmap
Status: Future
Milestone
No milestone
Development

No branches or pull requests
4 participants
@josh-chamberlain @maxachis @joshuagraber @phillitrOSU