From 90e3098a3a979004b8f871bec229d706ee7d9b72 Mon Sep 17 00:00:00 2001 From: Peter van Dijk Date: Mon, 6 Jan 2025 14:48:54 +0100 Subject: [PATCH 1/2] coding guidelines: remove bool advice that conflicts with clang-tidy --- CODING_GUIDELINES.md | 1 - 1 file changed, 1 deletion(-) diff --git a/CODING_GUIDELINES.md b/CODING_GUIDELINES.md index 63959bb43e25..7dd0671f0f07 100644 --- a/CODING_GUIDELINES.md +++ b/CODING_GUIDELINES.md @@ -611,7 +611,6 @@ Without `auto`, code might still compile but trigger a copy or worse. ## Explicit Comparisons * Compare numerical values with `== 0` or `!= 0` explicitly ; -* Compare to `false` explicitly, which is easier to read ; * Compare to `nullptr` for the same reason. ## Initialization From 60eba86b8a10a62c60b39a80170832eeb9c5789e Mon Sep 17 00:00:00 2001 From: Peter van Dijk Date: Mon, 6 Jan 2025 14:53:29 +0100 Subject: [PATCH 2/2] better text Co-authored-by: Miod Vallat --- CODING_GUIDELINES.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CODING_GUIDELINES.md b/CODING_GUIDELINES.md index 7dd0671f0f07..e8afa15962ad 100644 --- a/CODING_GUIDELINES.md +++ b/CODING_GUIDELINES.md @@ -611,7 +611,7 @@ Without `auto`, code might still compile but trigger a copy or worse. ## Explicit Comparisons * Compare numerical values with `== 0` or `!= 0` explicitly ; -* Compare to `nullptr` for the same reason. +* Compare to `nullptr`, which is easier to read. ## Initialization