-
-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 1.18 #2329
Comments
No need for luck, as soon as someone starts working on it, it’ll get done :) |
https://github.com/PrismarineJS/prismarine-contribute#updating-to-new-minecraft-versions can help you make progress on this @crazywhalecc |
I'll try it but my day job is busy, there is no guarantee that it can be done 😢 |
It has been 6 days, any updates on 1.18 support? |
It's waiting for someone who wants it to work on it. If you're not sure how it's always a great time to learn, just look at how some of the previous updates were done. If that's not possible you can try and promote some progress by using the issue hunter bounties, I think it's a good motivator. Otherwise it's all dependent on someone with free time and in a good mood, which could be tomorrow or maybe next month :) |
Asking for features in the run up to or during American universities's finals week is a crap shoot. I intend to work on this once I've completed my campaign against Differential Equations & Linear Algebra |
related PrismarineJS/minecraft-data#474 |
Unable to fund, issuehunter is broken .-. |
Any updates? It looks like the issue hunter page for this issue is broken. :( |
I feel that in the end, everyone is waiting for someone to update, but no one updates, except the maintainer. |
I addressed this two weeks ago, we're finishing our finals, and we even made progress on it already (NMP supports 1.18). I did very OK on Linear Algebra, thanks for asking. |
Regarding issue hunt, yes it's broken. Feel free to contact them, I tried without success |
If it's literally just this issue we could simply move the discussion to a new one for the purpose of linking to issue hunt. It's not like this issue has collected a lot of useful discussion. |
Hmm yeah indeed it seems it's not all issues and maybe only a few |
Sorry hadn't realized! I was asking as a general question for anyone. :( I am trying to figure out how to contribute, but I cant piece together what specifically needs to be updated or how. Like for instance in pchunk, it says it need a update. As to what need to be changed, I can't figure it out. There is a lot of things that happen that reference each other over multiple repositories. So trying to piece together what something does, and what need to be changed to make it work, or why it doesn't work, is hard. I don't mean to be unsympathetic, it was more geared to ask anyone where we are currently with a little more specificity. If you still have more finals, Good Luck! :) |
I don't know by any means if I executed things correctly, but according to https://github.com/PrismarineJS/prismarine-contribute#updating-to-new-minecraft-versions you first have to update PrismarineJS/minecraft-data, and in https://github.com/PrismarineJS/minecraft-data/blob/master/doc/add-data-new-version.md I found a list that need to be done. I was trying to execute the first one and I think you have to use the version history of https://wiki.vg/Protocol to update the last already existing JSON file. Would be nice to hear if this is correct. Btw always nice to use a file diff tool |
just realised minecraft-data is already updated nice |
the protocol file in mcdata is already updated indeed feel free to join our discord (in particular #contributor room) for more step by step guidance |
In dataPaths.json everything except protocol.json is referenced to 1.17.1 and below and README is already updated with 1.18. EDIT: node-minecraft-protocol is updated too so it's just mineflayer |
Yes, so it's not updated |
We now have most of the data for 1.18 |
Next step is chunk dumper + pchunk |
Thanks a ton for maintaining this project! Do you have an estimate when 1.18 support will be available? |
No, and for future reference we never provide ETAs. Up-to-date information about current work can be found in #contribute of the Discord if you want to help though. |
Work on pris-chunk is in progress For those following the saga, I passed Differential Equations & Linear Algebra with a C+ |
1.18 pchunk is at review. Big question right now is what to do about biome support. Biomes are effectively broken on any non-vanilla server due to Biome data becoming fully dynamic, principally since the introduction of the LoginData packet but very really in 1.18. The good news is no one really cares, as biome support is barely used by anyone, the bad news is if we ship with it broken it will likely stay broken. |
the next step is getting materials.json in minecraft data for 1.18 |
An anonymous user has contributed $15.00 to this issue on Rysolv. |
rom1504 has contributed $5.00 to this issue on Rysolv. |
Whoever does the works, well deserved :) |
Users have contributed $10.00 & $20.00 to this issue on Rysolv. |
An anonymous user has contributed $50.00 to this issue on Rysolv. |
An anonymous user has contributed $87.00 to this issue on Rysolv. |
now done |
No description provided.
The text was updated successfully, but these errors were encountered: