Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 1.18 #2329

Closed
crazywhalecc opened this issue Dec 3, 2021 · 36 comments
Closed

Support 1.18 #2329

crazywhalecc opened this issue Dec 3, 2021 · 36 comments
Labels
funded new feature Stage3 idea is precisely specified, only coding is left to do

Comments

@crazywhalecc
Copy link

crazywhalecc commented Dec 3, 2021

No description provided.

@crazywhalecc crazywhalecc added new feature Stage1 just created by someone new to the project, we don't know yet if it deserves an implementation / a f labels Dec 3, 2021
@u9g
Copy link
Member

u9g commented Dec 3, 2021

No need for luck, as soon as someone starts working on it, it’ll get done :)

@rom1504
Copy link
Member

rom1504 commented Dec 3, 2021

@rom1504 rom1504 changed the title Any luck with 1.18? Support 1.18 Dec 3, 2021
@rom1504 rom1504 added Stage3 idea is precisely specified, only coding is left to do and removed Stage1 just created by someone new to the project, we don't know yet if it deserves an implementation / a f labels Dec 3, 2021
@crazywhalecc
Copy link
Author

I'll try it but my day job is busy, there is no guarantee that it can be done 😢

@kegri
Copy link

kegri commented Dec 6, 2021

It has been 6 days, any updates on 1.18 support?

@extremeheat
Copy link
Member

It's waiting for someone who wants it to work on it. If you're not sure how it's always a great time to learn, just look at how some of the previous updates were done. If that's not possible you can try and promote some progress by using the issue hunter bounties, I think it's a good motivator. Otherwise it's all dependent on someone with free time and in a good mood, which could be tomorrow or maybe next month :)

@nickelpro
Copy link
Member

It has been 6 days, any updates on 1.18 support?

Asking for features in the run up to or during American universities's finals week is a crap shoot.

I intend to work on this once I've completed my campaign against Differential Equations & Linear Algebra

@rom1504
Copy link
Member

rom1504 commented Dec 8, 2021

related PrismarineJS/minecraft-data#474

@constantins2001
Copy link
Contributor

Unable to fund, issuehunter is broken .-.

@DelanoLeslie
Copy link

Any updates? It looks like the issue hunter page for this issue is broken. :(

@crazywhalecc
Copy link
Author

I feel that in the end, everyone is waiting for someone to update, but no one updates, except the maintainer.

@nickelpro
Copy link
Member

I addressed this two weeks ago, we're finishing our finals, and we even made progress on it already (NMP supports 1.18). I did very OK on Linear Algebra, thanks for asking.

@rom1504
Copy link
Member

rom1504 commented Dec 19, 2021

Regarding issue hunt, yes it's broken. Feel free to contact them, I tried without success
Does anyone have suggestions for an alternative?

@nickelpro
Copy link
Member

If it's literally just this issue we could simply move the discussion to a new one for the purpose of linking to issue hunt. It's not like this issue has collected a lot of useful discussion.

@rom1504
Copy link
Member

rom1504 commented Dec 19, 2021

Hmm yeah indeed it seems it's not all issues and maybe only a few
However not sure if I want to keep trusting people money to this platform if they can't fix this or at least answer to support requests.

@DelanoLeslie
Copy link

DelanoLeslie commented Dec 20, 2021

I addressed this two weeks ago, we're finishing our finals, and we even made progress on it already (NMP supports 1.18). I did very OK on Linear Algebra, thanks for asking.

Sorry hadn't realized! I was asking as a general question for anyone. :( I am trying to figure out how to contribute, but I cant piece together what specifically needs to be updated or how. Like for instance in pchunk, it says it need a update. As to what need to be changed, I can't figure it out. There is a lot of things that happen that reference each other over multiple repositories. So trying to piece together what something does, and what need to be changed to make it work, or why it doesn't work, is hard. I don't mean to be unsympathetic, it was more geared to ask anyone where we are currently with a little more specificity. If you still have more finals, Good Luck! :)

@tippfehlr
Copy link

I don't know by any means if I executed things correctly, but according to https://github.com/PrismarineJS/prismarine-contribute#updating-to-new-minecraft-versions you first have to update PrismarineJS/minecraft-data, and in https://github.com/PrismarineJS/minecraft-data/blob/master/doc/add-data-new-version.md I found a list that need to be done. I was trying to execute the first one and I think you have to use the version history of https://wiki.vg/Protocol to update the last already existing JSON file.
My fork: tippf3hlr/minecraft-data/data/pc/1.18/protocol.json but I changed one or two things so nothing that matters.

Would be nice to hear if this is correct.

Btw always nice to use a file diff tool

@tippfehlr
Copy link

just realised minecraft-data is already updated nice

@rom1504
Copy link
Member

rom1504 commented Dec 20, 2021

the protocol file in mcdata is already updated indeed
the next step there would be to add the blocks, items,.. data
using https://github.com/PrismarineJS/minecraft-jar-extractor

feel free to join our discord (in particular #contributor room) for more step by step guidance

@tippfehlr
Copy link

tippfehlr commented Dec 21, 2021

the next step there would be to add the blocks, items,.. data

In dataPaths.json everything except protocol.json is referenced to 1.17.1 and below and README is already updated with 1.18.
would the next step be updating node-minecraft-protocol -> mineflayer?

EDIT: node-minecraft-protocol is updated too so it's just mineflayer

@tippfehlr
Copy link

#2339

@rom1504
Copy link
Member

rom1504 commented Dec 21, 2021

In dataPaths.json everything except protocol.json is referenced to 1.17.1 and below

Yes, so it's not updated

@rom1504
Copy link
Member

rom1504 commented Dec 21, 2021

We now have most of the data for 1.18

@rom1504
Copy link
Member

rom1504 commented Dec 21, 2021

Next step is chunk dumper + pchunk
PrismarineJS/minecraft-chunk-dumper#24

@mvnd06
Copy link

mvnd06 commented Dec 28, 2021

Thanks a ton for maintaining this project! Do you have an estimate when 1.18 support will be available?

@nickelpro
Copy link
Member

No, and for future reference we never provide ETAs. Up-to-date information about current work can be found in #contribute of the Discord if you want to help though.

@nickelpro
Copy link
Member

Work on pris-chunk is in progress
PrismarineJS/prismarine-chunk#150

For those following the saga, I passed Differential Equations & Linear Algebra with a C+

@nickelpro
Copy link
Member

1.18 pchunk is at review.

Big question right now is what to do about biome support. Biomes are effectively broken on any non-vanilla server due to Biome data becoming fully dynamic, principally since the introduction of the LoginData packet but very really in 1.18. The good news is no one really cares, as biome support is barely used by anyone, the bad news is if we ship with it broken it will likely stay broken.

@rom1504
Copy link
Member

rom1504 commented Jan 3, 2022

the next step is getting materials.json in minecraft data for 1.18

@rom1504
Copy link
Member

rom1504 commented Jan 3, 2022

@rysolv-bot
Copy link

An anonymous user has contributed $15.00 to this issue on Rysolv.

The total bounty is now $15.00. Solve this issue on Rysolv to earn this bounty.

@rysolv-bot
Copy link

rom1504 has contributed $5.00 to this issue on Rysolv.

The total bounty is now $20.00. Solve this issue on Rysolv to earn this bounty.

@constantins2001
Copy link
Contributor

Whoever does the works, well deserved :)

@rom1504 rom1504 added the funded label Jan 4, 2022
@rom1504 rom1504 pinned this issue Jan 4, 2022
@rysolv-bot
Copy link

Users have contributed $10.00 & $20.00 to this issue on Rysolv.

The total bounty is now $50.00. Solve this issue on Rysolv to earn this bounty.

@rysolv-bot
Copy link

An anonymous user has contributed $50.00 to this issue on Rysolv.

The total bounty is now $100.00. Solve this issue on Rysolv to earn this bounty.

@rysolv-bot
Copy link

An anonymous user has contributed $87.00 to this issue on Rysolv.

The total bounty is now $187.00. Solve this issue on Rysolv to earn this bounty.

@rom1504
Copy link
Member

rom1504 commented Jan 22, 2022

now done
thanks to

@rom1504 rom1504 closed this as completed Jan 22, 2022
@rom1504 rom1504 unpinned this issue Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
funded new feature Stage3 idea is precisely specified, only coding is left to do
Projects
None yet
Development

No branches or pull requests