Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential improvement to statTally() -- bin splitting #683

Open
rpruim opened this issue Nov 8, 2017 · 0 comments
Open

Potential improvement to statTally() -- bin splitting #683

rpruim opened this issue Nov 8, 2017 · 0 comments

Comments

@rpruim
Copy link
Contributor

rpruim commented Nov 8, 2017

If the value of the test statistic is on the edge of a bin, then the shading added to the histogram can misrepresent the p-value a bit (since the data in a bin may not be uniformly distributed over the range of the bin).

The best, general fix is likely to split such bins. So all bins except bins containing the test statistic (possible also its additive inverse) would be the same size -- the exceptional cases would be narrower.

Can't decide whether this is worth the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant