Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do we need expand2sqaure in scorers? #44

Open
Hoi2022 opened this issue Dec 30, 2024 · 0 comments
Open

Why do we need expand2sqaure in scorers? #44

Hoi2022 opened this issue Dec 30, 2024 · 0 comments

Comments

@Hoi2022
Copy link

Hoi2022 commented Dec 30, 2024

Hello, thanks for your great works.

However, I find that the preprocess inside this looks weird.

The input image is first expanded to a square one, with extra mean-color margins by applying the expand2sqaure function.

I visualized a preprocessed image, which looks like this:

proproc

while the original image is:

image

My teammate also reports that larger aspect ratio results in lower aesthetic score. So we are wondering if this preprocess is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant