Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prod(ClosedProd(), Beta(1.,1.), Beta(1.,1.)) defaults to UnspecifiedProd #26

Closed
wmkouw opened this issue Oct 23, 2024 · 1 comment
Closed
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@wmkouw
Copy link
Member

wmkouw commented Oct 23, 2024

Expected behaviour for prod(ClosedProd(), Beta(1.,1.), Beta(1.,1.)) is

Beta{Float64}(α=1.0, β=1.0)

But BayesBase v1.5.0 defaults to UnspecifiedProd;

MethodError: no method matching prod(::BayesBase.UnspecifiedProd, ::Beta{Float64}, ::Beta{Float64})

Closest candidates are:
  prod(::BayesBase.UnspecifiedProd, ::Any, ::Any)
   @ BayesBase ~/.julia/packages/BayesBase/VaygE/src/prod.jl:33
  prod(!Matched::GenericProd, ::Any, ::Any, !Matched::ProductOf, !Matched::Any)
   @ BayesBase ~/.julia/packages/BayesBase/VaygE/src/prod.jl:280
  prod(!Matched::GenericProd, ::Any, ::Any, !Matched::Any, !Matched::ProductOf)
   @ BayesBase ~/.julia/packages/BayesBase/VaygE/src/prod.jl:313
  ...


Stacktrace:
 [1] prod(strategy::BayesBase.UnspecifiedProd, left::Beta{Float64}, right::Beta{Float64})
   @ BayesBase ~/.julia/packages/BayesBase/VaygE/src/prod.jl:34
 [2] prod(::PreserveTypeProd{Distribution}, left::Beta{Float64}, right::Beta{Float64})
   @ BayesBase ~/.julia/packages/BayesBase/VaygE/src/prod.jl:77
 [3] prod(::ClosedProd, left::Beta{Float64}, right::Beta{Float64})
   @ BayesBase ~/.julia/packages/BayesBase/VaygE/src/prod.jl:125
 [4] top-level scope

PreserveTypeProd{Distribution} does not seem to dispatch to the product rule for Beta distributions. I'm not familiar with how this product strategy finds the appropriate Distribution products. Any thoughts anyone?

@wmkouw wmkouw added bug Something isn't working help wanted Extra attention is needed labels Oct 23, 2024
@wmkouw wmkouw self-assigned this Oct 23, 2024
@wmkouw
Copy link
Member Author

wmkouw commented Oct 23, 2024

This was a version mismatch with RxInfer 2.13 and ReactiveMP 3.x.

@wmkouw wmkouw closed this as completed Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant