New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`FastCholesky` support for `UniformScaling` #6

Open

bartvanerp opened this issue Oct 6, 2023 · 0 comments

Member

bartvanerp commented Oct 6, 2023 •

edited

Loading

I saw that we do not support fastcholesky(::UniformScaling)
https://github.com/biaslab/FastCholesky.jl/blob/087eb8e71d5003ce56fdd9909131785c47fad333/src/FastCholesky.jl#L39C1-L48C4

I suppose we can easily provide support by

fastcholesky(A::UniformScaling) = UniformScaling(sqrt(A.λ))

(with a check for positiveness of A.λ)

The text was updated successfully, but these errors were encountered:

albertpod added this to RxInfer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment