Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

real_time_factor #67

Closed
stakaz opened this issue Sep 9, 2024 · 1 comment · Fixed by #68
Closed

real_time_factor #67

stakaz opened this issue Sep 9, 2024 · 1 comment · Fixed by #68
Assignees

Comments

@stakaz
Copy link

stakaz commented Sep 9, 2024

Hello,

I have a short question: basically, when trying to use your getting started code and setting real_time_factor in for the environment:

#...
environment = RxEnvironment(BayesianThermostat(0.0, -10.0, 10.0); emit_every_ms = 900, real_time_factor=5)
#...

the temperature still decreases at the same speed in real time. Do I misunderstand the purpose of this argument or is it a bug?

Thanks for a great work ;)

@wouterwln wouterwln self-assigned this Sep 9, 2024
@wouterwln
Copy link
Member

Hi @stakaz , thanks for trying out RxEnvironments.jl! You're absolutely right, I must've overlooked this when coding up the RxEnvironment constructor. I'm working on the fix and will have it ready in a couple of minutes

@wouterwln wouterwln linked a pull request Sep 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants