Locally testing timewarp

[oPromessa]

Trying to run local tests for --timewarp. Guidance is appreciated 😄

Manual tests

• Ran manual tests as per tests/README.md. Some remarks
  • Added code OS_VER[0] == "12" on tests/test_cli_timewarp.py and contest.py ( I'm on MacOS 12.7.6) to allow tests to run with TestTimeWarp-10.15.7.photoslibrary(which is then updated by Mac Photos)
  • An error following the copy of Test library into ~/Pictures while trying to switch Libraries... but then I open the Test Library manually and tests continue.
    • The application “(null)” does not have permission to open “TestTimeWarp-10.15.7.photoslibrary.”
• Although I've checked and the TZ setting is taking effect on the test environment: DEBUG ===== os.environ['TZ']='US/Pacific'
  • Test results still show up a bit off on the Time/hours!
  • My OS is currently set on WEST timezone.

(...)
___________________________________________________ test_date_added[2022-01-01 01:02:03-expected1] ____________________________________________________

(...)    
        result = runner.invoke(
            timewarp,
            ["--inspect", "--plain", "--force"],
            terminal_width=TERMINAL_WIDTH,
        )
)        output_values = parse_inspect_output(result.output, date_added=True)
>       assert output_values[0].date_added == expected.date_added
E       AssertionError: assert '2022-01-01 01:02:03-0800' == '2022-01-01 01:02:03-0700'
E         - 2022-01-01 01:02:03-0700
E         ?                      ^
E         + 2022-01-01 01:02:03-0800
E         ?                      ^

tests/test_cli_timewarp.py:1106: AssertionError
_____________________________________________________________ test_date_added_from_photo ______________________________________________________________

(...))
    
        result = runner.invoke(
            timewarp,
            ["--inspect", "--plain", "--force"],
            terminal_width=TERMINAL_WIDTH,
        )
        output_values = parse_inspect_output(result.output, date_added=True)
        expected = TEST_DATA["date_added_from_photo"]["expected"]
>       assert output_values[0].date_added == expected.date_added
E       AssertionError: assert '2023-01-19 21:02:03-0800' == '2023-01-19 20:02:03-0700'
E         - 2023-01-19 20:02:03-0700
E         ?             ^        ^
E         + 2023-01-19 21:02:03-0800
E         ?             ^        ^

tests/test_cli_timewarp.py:1132: AssertionError

Summary Tests

• I believe the "26 failed, 35 passed in 119.91s (0:01:59)" failed tests are all related with this output difference!

=============================================================== short test summary info ===============================================================
FAILED tests/test_cli_timewarp.py::test_inspect - AssertionError: assert [InspectValues(filename='IMG_6501.jpeg', uuid='2F00448D-3C0D-477A-9B10-5F21DCAB405A', date_local='2021-10-02 12:40:07-0700'...
FAILED tests/test_cli_timewarp.py::test_date - assert datetime.datetime(2020, 9, 1, 20, 40, 7) == datetime.datetime(2020, 9, 1, 12, 40, 7)
FAILED tests/test_cli_timewarp.py::test_date_delta[1-2020-09-02 12:40:07-0700] - AssertionError: assert '2020-09-02 20:40:07-0700' == '2020-09-02 12:40:07-0700'
FAILED tests/test_cli_timewarp.py::test_date_delta[1 day-2020-09-03 12:40:07-0700] - AssertionError: assert '2020-09-03 20:40:07-0700' == '2020-09-03 12:40:07-0700'
FAILED tests/test_cli_timewarp.py::test_date_delta[1 week-2020-09-10 12:40:07-0700] - AssertionError: assert '2020-09-10 20:40:07-0700' == '2020-09-10 12:40:07-0700'
FAILED tests/test_cli_timewarp.py::test_date_delta[-1-2020-09-09 12:40:07-0700] - AssertionError: assert '2020-09-09 20:40:07-0700' == '2020-09-09 12:40:07-0700'
FAILED tests/test_cli_timewarp.py::test_date_delta[-1 day-2020-09-08 12:40:07-0700] - AssertionError: assert '2020-09-08 20:40:07-0700' == '2020-09-08 12:40:07-0700'
FAILED tests/test_cli_timewarp.py::test_date_delta[-1 week-2020-09-01 12:40:07-0700] - AssertionError: assert '2020-09-01 20:40:07-0700' == '2020-09-01 12:40:07-0700'
FAILED tests/test_cli_timewarp.py::test_compare_exif_3[expected0] - AssertionError: assert CompareValues(filename='IMG_6520.jpeg', uuid='53615D56-91F7-4908-81F1-B93B5DEA7449', date_photos='2021-10-02 20:54:36', dat...
FAILED tests/test_cli_timewarp.py::test_match[-0500-2021-10-02 12:54:36-0500] - AssertionError: assert '2021-10-02 20:54:36-0500' == '2021-10-02 12:54:36-0500'
FAILED tests/test_cli_timewarp.py::test_match[+01:00-2021-10-02 12:54:36+0100] - AssertionError: assert '2021-10-02 20:54:36+0100' == '2021-10-02 12:54:36+0100'
FAILED tests/test_cli_timewarp.py::test_push_exif_1[True--0300-+1 hour-2021-10-02 13:56:11-0300-2021:10:02 13:56:11--03:00] - AssertionError: assert '2021-10-02 21:56:11-0300' == '2021-10-02 13:56:11-0300'
FAILED tests/test_cli_timewarp.py::test_push_exif_1[False--0400-+2 hours-2021-10-02 14:56:11-0400-2021:10:02 14:56:11--04:00] - AssertionError: assert '2021-10-02 22:56:11-0400' == '2021-10-02 14:56:11-0400'
FAILED tests/test_cli_timewarp.py::test_pull_exif_no_time - AssertionError: assert CompareValues(filename='IMG_6526.jpeg', uuid='1A61156A-5747-42DE-A9B3-4A468CC49D9E', date_photos='2021-10-02 23:15:00', dat...
FAILED tests/test_cli_timewarp.py::test_pull_exif_no_offset - AssertionError: assert CompareValues(filename='IMG_6517.jpeg', uuid='C4D952AF-983D-438E-9070-6310B1BC4826', date_photos='2021-10-02 20:50:00', dat...
FAILED tests/test_cli_timewarp.py::test_pull_exif_no_data - AssertionError: assert CompareValues(filename='IMG_6506.jpeg', uuid='7E9DF2EE-A5B0-4077-80EC-30565221A3B9', date_photos='2021-10-09 00:11:09', dat...
FAILED tests/test_cli_timewarp.py::test_pull_exif_no_data_use_file_time - AssertionError: assert CompareValues(filename='IMG_6506.jpeg', uuid='7E9DF2EE-A5B0-4077-80EC-30565221A3B9', date_photos='2021-10-09 00:11:09', dat...
FAILED tests/test_cli_timewarp.py::test_video_compare_exif[expected0] - AssertionError: assert CompareValues(filename='IMG_6551.mov', uuid='16BEC0BE-4188-44F1-A8F1-7250E978AD12', date_photos='2021-10-05 03:01:03', date...
FAILED tests/test_cli_timewarp.py::test_video_date_delta[-1 day-2021-10-03 19:01:03-0700] - AssertionError: assert '2021-10-04 03:01:03-0700' == '2021-10-03 19:01:03-0700'
FAILED tests/test_cli_timewarp.py::test_video_time_delta[+1 hour-2021-10-03 20:01:03-0700] - AssertionError: assert '2021-10-04 04:01:03-0700' == '2021-10-03 20:01:03-0700'
FAILED tests/test_cli_timewarp.py::test_video_date[2021-10-04-2021-10-04 20:01:03-0700] - AssertionError: assert '2021-10-04 04:01:03-0700' == '2021-10-04 20:01:03-0700'
FAILED tests/test_cli_timewarp.py::test_parse_date - AssertionError: assert '2023-01-20 01:02:03-0800' == '2023-01-20 00:02:03-0700'
FAILED tests/test_cli_timewarp.py::test_parse_date_tz - AssertionError: assert '2023-01-19 21:02:03-0800' == '2023-01-19 20:02:03-0700'
FAILED tests/test_cli_timewarp.py::test_date_added[2022-01-01-expected0] - AssertionError: assert '2022-01-01 00:00:00-0800' == '2022-01-01 00:00:00-0700'
FAILED tests/test_cli_timewarp.py::test_date_added[2022-01-01 01:02:03-expected1] - AssertionError: assert '2022-01-01 01:02:03-0800' == '2022-01-01 01:02:03-0700'
FAILED tests/test_cli_timewarp.py::test_date_added_from_photo - AssertionError: assert '2023-01-19 21:02:03-0800' == '2023-01-19 20:02:03-0700'
====================================================== 26 failed, 35 passed in 119.91s (0:01:59) ======================================================

[RhetTbull]

All the time warp tests fail in a different time zone. I'm currently working to fix this but it's not easy. Anything involving a time zone in OSXPhotos is very difficult to test unfortunately. I'm in the midst of a big rewrite of the date /time handling code in OSXPhotos and will fix these tests as part of that