Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skill crashes ungracefully if a required parameter is not set #91

Open
matthias-mayr opened this issue Feb 29, 2024 · 0 comments
Open
Labels
ROS 1 Issue affects ROS 1 ROS 2 Issue affects ROS 2

Comments

@matthias-mayr
Copy link
Member

Here a new skill has parameters "Target" and "Task", but the parent skill does not set them.
The expectation is that this is displayed in a nicer way than showing the exception in the UI

[skill_manager_node-4]   File "/home/matthias/Workspaces/skiros2_ws/build/skiros2_skill/skiros2_skill/core/visitors.py", line 145, in processNode
[skill_manager_node-4]     state = self.execute(procedure)
[skill_manager_node-4]   File "/home/matthias/Workspaces/skiros2_ws/build/skiros2_skill/skiros2_skill/core/skill_utils.py", line 229, in execute
[skill_manager_node-4]     if not self._ground(skill):
[skill_manager_node-4]   File "/home/matthias/Workspaces/skiros2_ws/build/skiros2_skill/skiros2_skill/core/skill_utils.py", line 181, in _ground
[skill_manager_node-4]     if not self._autoParametrizeBB(skill):
[skill_manager_node-4]   File "/home/matthias/Workspaces/skiros2_ws/build/skiros2_skill/skiros2_skill/core/skill_utils.py", line 143, in _autoParametrizeBB
[skill_manager_node-4]     raise Exception("Missing required parameter(s): {}".format(missing_params))
[skill_manager_node-4] Exception: Missing required parameter(s): ['Target', 'Task']
[skill_manager_node-4] 
@matthias-mayr matthias-mayr added ROS 1 Issue affects ROS 1 ROS 2 Issue affects ROS 2 labels Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ROS 1 Issue affects ROS 1 ROS 2 Issue affects ROS 2
Projects
None yet
Development

No branches or pull requests

1 participant