Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CANCEL-button placement inconsistent #188

Closed
VladGhitulescu opened this issue Nov 9, 2023 · 4 comments
Closed

CANCEL-button placement inconsistent #188

VladGhitulescu opened this issue Nov 9, 2023 · 4 comments
Assignees

Comments

@VladGhitulescu
Copy link

Hey,

the CANCEL-button is placed both on the left and right side (see the attached screenshots) which leads to accidental clicks on the wrong button.

CleanShot 2023-11-09 at 05 50 55@2x

CleanShot 2023-11-09 at 05 51 39@2x

On the Mac the default position for CANCEL is on the left (see again the attached screenshots).

CleanShot 2023-11-09 at 05 53 35@2x
CleanShot 2023-11-09 at 05 53 05@2x

Regards,
Vlad

@jmgrassau
Copy link
Member

Hi Vlad,

ah, good point! Of course this should be consistent at least within ABAP cleaner. Not sure about the best order, though, for example MS Word (on Windows) would give me:

image

But since we are an ADT / Eclipse plug-in, I guess adjusting to ADT standards would be the best way to go. E.g., if I close an editor with an unsaved change, I get:

image

Menu "Window / Preferences" shows:

image

A wizard like "File / New / ABAP Project" has:

image

Do you get the same on macOS or is that OS-specific?

Kind regards,
Jörg-Michael

@VladGhitulescu
Copy link
Author

VladGhitulescu commented Nov 9, 2023

Hello again JM,

Eclipse aligns with the OS guidelines:

CleanShot 2023-11-09 at 09 27 12

Regards,
Vlad

@jmgrassau jmgrassau self-assigned this Jan 1, 2024
@jmgrassau
Copy link
Member

Hi Vlad,

thanks again for opening this issue! With the next release, the order of OK / Cancel buttons should be in line with the respective OS standards, i.e. "OK – Cancel" for Windows, but "Cancel – OK" for macOS and Linux.

Kind regards,
Jörg-Michael

@jmgrassau
Copy link
Member

Hi Vlad,

thanks again for taking such a close look at these buttons and their order – this should now be fixed with version 1.13.0, which was just released!

Kind regards,
Jörg-Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants