Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDL: Standardize spaces around colon, coma... with namespaces #359

Closed
jrodriguez-rc opened this issue Sep 19, 2024 · 3 comments
Closed

DDL: Standardize spaces around colon, coma... with namespaces #359

jrodriguez-rc opened this issue Sep 19, 2024 · 3 comments
Assignees
@jmgrassau
Labels
bug Something isn't working

Comments

@jrodriguez-rc
Copy link

This rule is adding spaces around the slashes of namespaces, converting this

define root view entity /RHP/C_DocumentDefTP
  provider contract transactional_query
  as projection on /RHP/R_DocumentDefTP

into

define root view entity / RHP / C_DocumentDefTP
  provider contract transactional_query
  as projection on / RHP / R_DocumentDefTP
@jmgrassau jmgrassau added the bug Something isn't working label Sep 19, 2024
@jmgrassau
Copy link
Member

Hi Jaime,

that's not good… thanks for reporting this, will fix asap!

Kind regards,
Jörg-Michael

jmgrassau added a commit to jmgrassau/abap-cleaner that referenced this issue Sep 19, 2024
@jmgrassau
fix Parser for identifiers with namespaces (SAP#359)
868bc62
jmgrassau added a commit that referenced this issue Sep 19, 2024
@jmgrassau
fix Parser for identifiers with namespaces (#359)
d982d2c
@jmgrassau jmgrassau self-assigned this Sep 19, 2024
@jmgrassau
Copy link
Member

Hi Jaime,

thanks again for reporting this bug so quickly – this should now be fixed with version 1.19.2, which was just released! I tried to create some extreme (but syntactically correct) examples to ensure that the distinction between using / as an arithmetic operator and using it for a namespace (or between using - as a sign and using it as an operator) is now correctly made:

image

Kind regards,
Jörg-Michael

@jrodriguez-rc
Copy link
Author

Thank you for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmgrassau jmgrassau

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrodriguez-rc @jmgrassau