Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the pipeline figure in example (and example) #143

Open
CasperWA opened this issue Sep 10, 2023 · 0 comments
Open

Update the pipeline figure in example (and example) #143

CasperWA opened this issue Sep 10, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@CasperWA
Copy link
Collaborator

CasperWA commented Sep 10, 2023

Please update the below figure. The filter strategy should come after the data resource strategy in the pipeline:

image

This is conceptually important. We have the partial pipeline documenting the data source (typically DataResource >> Parse >> Mapping). That should be treated as one unit and always come first in the pipeline. The filter is not a part of the documentation of the data resource, but is a part of our application that selects the subset of all the data in the data resource we are interested in. It should use the initialize() method to specify the query such that only the information we need is fetched from the data resource.

I did this originally, but unfortunately the session object is not returned correctly from the "filter strategy", so I had to switch them around. I believe this issue is being resolved in OTElib, but this is an issue.
Furthermore, retrieving the data from the session object is plain wrong and should not be done like this. But that's out-of-scope of this tutorial to fix.

Originally posted by @CasperWA in #125 (comment)

@CasperWA CasperWA added the documentation Improvements or additions to documentation label Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant