Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer-review #1

Open
zhamadeh opened this issue Sep 23, 2018 · 0 comments
Open

Peer-review #1

zhamadeh opened this issue Sep 23, 2018 · 0 comments

Comments

@zhamadeh
Copy link

Peer Review

README File

You did a good job structuring the flow of your readme file using different sized headers. You also incorporated a wide variety of markdown features. This file served its purpose of describing the repo and introducing yourself.

Rmd/md File

You showed many useful functions for exploring the data set with a brief explanation of what each function does. This file was also structured well. For the future, I would make sure to comment on the output of each function (eg. are the results expected, are there outliers etc.)

Overall

The assignment was well done. For future assignments that will have more files it might be beneficial for the viewer to have folders in your repo to group similar files together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant