Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer Review from Curtis Fox #1

Open
curtis77 opened this issue Nov 17, 2018 · 0 comments
Open

Peer Review from Curtis Fox #1

curtis77 opened this issue Nov 17, 2018 · 0 comments

Comments

@curtis77
Copy link


Topic Excellent Satisfactory Needs Work
Coding style ✔️
Coding strategy ✔️
Presentation: graphs
Presentation: tables
Achievement, creativity ✔️
Ease of access ✔️

Remarks:

  • I didn't fill in the rows for graphs or tables, since I didn't see any used in this repo.
  • Mode function is easy to read, as you made use of piping and proper indentation.
  • Code is properly documented with parameters, a title, and the return value.
  • You included 3 tests as required!
  • Nice job creating a new package, rather than modifying an old one!
  • Try not to include just a zip file in the repo from now on, it makes looking through the repo more difficult.
  • I wasn't able to install the package with the given command in the README (possibly a mistake on my end though).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant