Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TA comments #3

Open
Rashedul opened this issue Nov 29, 2018 · 5 comments
Open

TA comments #3

Rashedul opened this issue Nov 29, 2018 · 5 comments

Comments

@Rashedul
Copy link

  • Its a great idea of making getmode package.

  • I am not sure why you uploaded a zip file!

  • install.packages("getmode") gets the message:

Warning in install.packages :
  package ‘getmode’ is not available (for R version 3.5.1)
  • The package readme included test examples and the vignette described the package very well.

  • Great coding style and strategies.

@MielleM
Copy link
Collaborator

MielleM commented Nov 30, 2018

Hi @Rashedul, thank you for the feedback!

Sorry about the issues with installing, I realized after the deadline had passed that I needed to put devtools::install_github() with a link to my repo. I think there was some confusion on my part about uploading the zipped file.

Other than the installation problem, were there other issues with the package? Everything runs as expected with it installed on my computer.

If I had to do it again, I probably wouldn't have made a new package-- I spent so much time troubleshooting problems that I didn't get as much time as I would have liked to work on the package itself.

@Rashedul
Copy link
Author

I downloaded the zip file and read the documents inside. It was a solid submission but I failed to install and check it. So it would be helpful for me if you can provide me a link of installation or, let me know how to install. As I mentioned earlier that the command you provided for installation is not working install.packages("getmode"). So I was not able to give >=90% grade. Thanks!

@MielleM
Copy link
Collaborator

MielleM commented Nov 30, 2018

I think devtools::install_github("STAT545-UBC-students/hw07-miellem") and then library(getmode) should work (it downloaded for me). I re-uploaded the identical contents of my zipped file to my repo so they would download. Let me know if there's an issue installing. Thank you for taking extra time with this! I didn't realize there would be problems installing as when I search the Packages window, getmode shows up for me with all appropriate documentation.

@Rashedul
Copy link
Author

Rashedul commented Dec 3, 2018

@MielleM ,

Thanks for putting some extra effort. It was able to install this version of the package, great job! I updated your grade. I should clarify that this hw was making a package and if it cant be installed, this is a problem.

@MielleM
Copy link
Collaborator

MielleM commented Dec 3, 2018

@Rashedul thank you so much for taking the extra time, I appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants