Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer-Review HW-09 for tanvimittal71 #2

Open
bassamjaved opened this issue Dec 3, 2018 · 0 comments
Open

Peer-Review HW-09 for tanvimittal71 #2

bassamjaved opened this issue Dec 3, 2018 · 0 comments

Comments

@bassamjaved
Copy link

Peer-Review HW-09 for tanvimittal71

Topic Excellent Satisfactory Needs Work
Coding style ✔️
Coding strategy ✔️
Achievement, creativity ✔️
Ease of access ✔️

Remarks:
-Overall, you've demonstrated that you can work with an existing Makefile and modify the pipeline with a novel analysis, so well done.
-Good analysis--it's not something trivial and it was integrated well.
-Your explanations in readme and report.html of your analysis were succinct and got the message across clearly. One thing I would suggest to your readme is to comment which files are the base ones and which ones are added in the pipeline. Of course, in a simple analysis like this, a reader doesn't have to spend too much time figuring out what you were doing. But if you plan to use Makefile in future projects outside of a classroom setting, then it would be good to get in the hang of adding a bit more clarity!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant