Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing attribute sramInactiveDays in LDAP and SCIM #1631

Closed
HarryKodden opened this issue Oct 8, 2024 · 4 comments · Fixed by #1632
Closed

Missing attribute sramInactiveDays in LDAP and SCIM #1631

HarryKodden opened this issue Oct 8, 2024 · 4 comments · Fixed by #1632
Milestone
v38

Comments

@HarryKodden
Copy link
Member

According to link we should publish the sramInactiveDays attribute.
At this moment that attribute is missing.
Repair action:

  • add attribute to SBS Api /api/plsc/sync
  • add attribute to PSLC to sync with LDAP
  • add attribute to SCIM to sync with SCIM
@HarryKodden HarryKodden self-assigned this Oct 8, 2024
@HarryKodden
Copy link
Member Author

PR submitted (1632)

@HarryKodden HarryKodden moved this from New to To be tested in SRAM development Oct 8, 2024
@HarryKodden
Copy link
Member Author

HarryKodden commented Oct 9, 2024 •
edited
Loading

Repair action:

☑ add attribute to SBS Api /api/plsc/sync (was already included via last_login_date)
☑ add attribute to PSLC to sync with LDAP (SURFscz/plsc#138)
☑ add attribute to SCIM to sync with SCIM (#1632)

@baszoetekouw baszoetekouw linked a pull request Oct 11, 2024 that will close this issue
Issue 1631 #1632
Merged
@baszoetekouw baszoetekouw added this to the v38 milestone Oct 11, 2024
@mrvanes
Copy link
Contributor

mrvanes commented Oct 28, 2024

Ik zie hele rare discrepanties hier in m'n local deploy:
Ik heb een user met sramInactiveDays 0 in ldap, maar 301 (!!!) in SCIM? En meerdere users met sramInactiveDays 30 in ldap en 33 in SCIM? 21 in ldap, 26 in SCIM? Maar ik zie ook overeenkomsten (ldap 0, SCIM 0)
Bovendien zie ik voor dezelfde user in 2 CO's een verschillende sramInactiveDays (0 en 300)? Die 300 is dan weer te linken aan de SCIM 301, maar dan een beetje fout?

@mrvanes mrvanes changed the title Missing attribute srmInactiveDays in LDAP and SCIM Missing attribute sramInactiveDays in LDAP and SCIM Oct 28, 2024
@mrvanes
Copy link
Contributor

mrvanes commented Nov 4, 2024

Works as expected

@sram-deploy-tools-automation sram-deploy-tools-automation bot moved this from To be deployed to Done in SRAM development Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
SRAM development
Status: Done
Milestone
v38
Development

Successfully merging a pull request may close this issue.

Issue 1631 SURFscz/SBS
3 participants
@baszoetekouw @HarryKodden @mrvanes